Skip to content

Commit

Permalink
8g: out of register bug
Browse files Browse the repository at this point in the history
Fixes #806.

R=ken2
CC=golang-dev
https://golang.org/cl/1281042
  • Loading branch information
rsc committed May 25, 2010
1 parent ea941f0 commit 6a06020
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/cmd/8g/cgen.c
Expand Up @@ -10,6 +10,8 @@
void
mgen(Node *n, Node *n1, Node *rg)
{
Node n2;

n1->op = OEMPTY;

if(n->addable) {
Expand All @@ -18,11 +20,13 @@ mgen(Node *n, Node *n1, Node *rg)
reg[n->val.u.reg]++;
return;
}
if(n->type->width > widthptr && !isfloat[n->type->etype])
tempname(n1, n->type);
else
regalloc(n1, n->type, rg);
tempname(n1, n->type);
cgen(n, n1);
if(n->type->width <= widthptr || isfloat[n->type->etype]) {
n2 = *n1;
regalloc(n1, n->type, rg);
gmove(&n2, n1);
}
}

void
Expand Down
19 changes: 19 additions & 0 deletions test/fixedbugs/bug283.go
@@ -0,0 +1,19 @@
// $G $D/$F.go || echo BUG: should compile

// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// http://code.google.com/p/go/issues/detail?id=806
// triggered out of registers on 8g

package main

type Point struct {
x int
y int
}

func dist(p0, p1 Point) float64 {
return float64((p0.x-p1.x)*(p0.x-p1.x) + (p0.y-p1.y)*(p0.y-p1.y))
}

0 comments on commit 6a06020

Please sign in to comment.