Skip to content

Commit

Permalink
[dev.typeparams] cmd/compile: remove outdate TODO in escape analysis
Browse files Browse the repository at this point in the history
We now understand the root cause of #47227, it will be fixed in #47317.

Change-Id: Ifcd44f887a0bd3195818df33e409bd3e818e0b27
Reviewed-on: https://go-review.googlesource.com/c/go/+/336610
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
  • Loading branch information
cuonglm committed Jul 22, 2021
1 parent 80127a7 commit 73162a5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/cmd/compile/internal/escape/call.go
Expand Up @@ -320,8 +320,6 @@ func (e *escape) rewriteArgument(argp *ir.Node, init *ir.Nodes, call ir.Node, fn
return
case ir.ONAME:
if arg.(*ir.Name).Class == ir.PFUNC {
// TODO(cuonglm): figure it why this is necessary, we should not depend on this to make
// ABI analyze works correctly (see #47227 and discussion in CL 334882).
return
}
}
Expand Down

0 comments on commit 73162a5

Please sign in to comment.