Skip to content

Commit

Permalink
[dev.typeparams] test: set -G=3 and enable more errorcheck tests in r…
Browse files Browse the repository at this point in the history
…un.go

Change-Id: I9591f7aeab0448aca661560bf3064e057b48293e
Reviewed-on: https://go-review.googlesource.com/c/go/+/286012
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
  • Loading branch information
griesemer committed Jan 23, 2021
1 parent a49e941 commit 7947df4
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions test/run.go
Expand Up @@ -786,13 +786,6 @@ func (t *test) run() {
"append",
"slice",
"typeassert",
"ssa/check_bce/debug",
"ssa/intrinsics/debug",
"ssa/opt/debug",
"ssa/prove/debug",
"ssa/likelyadjust/debug",
"ssa/insert_resched_checks/off",
"ssa/phiopt/debug",
"defer",
"nil",
} {
Expand All @@ -806,7 +799,7 @@ func (t *test) run() {
}

// Run errorcheck again with -G option (new typechecker).
cmdline = []string{goTool(), "tool", "compile", "-G", "-C", "-e", "-o", "a.o"}
cmdline = []string{goTool(), "tool", "compile", "-G=3", "-C", "-e", "-o", "a.o"}
// No need to add -dynlink even if linkshared if we're just checking for errors...
cmdline = append(cmdline, flags...)
cmdline = append(cmdline, long)
Expand Down Expand Up @@ -1938,8 +1931,6 @@ var excluded = map[string]bool{
"const2.go": true, // types2 not run after syntax errors
"ddd1.go": true, // issue #42987
"directive.go": true, // misplaced compiler directive checks
"embedfunc.go": true, // error reported by irgen (only runs with -G=3)
"embedvers.go": true, // error reported by backend (only runs with -G=3)
"float_lit3.go": true, // types2 reports extra errors
"import1.go": true, // types2 reports extra errors
"import5.go": true, // issue #42988
Expand Down Expand Up @@ -1967,7 +1958,6 @@ var excluded = map[string]bool{
"fixedbugs/issue11614.go": true, // types2 reports an extra error
"fixedbugs/issue13415.go": true, // declared but not used conflict
"fixedbugs/issue14520.go": true, // missing import path error by types2
"fixedbugs/issue14540.go": true, // error reported by noder (not running for types2 errorcheck test)
"fixedbugs/issue16428.go": true, // types2 reports two instead of one error
"fixedbugs/issue17038.go": true, // types2 doesn't report a follow-on error (pref: types2)
"fixedbugs/issue17645.go": true, // multiple errors on same line
Expand Down

0 comments on commit 7947df4

Please sign in to comment.