Skip to content

Commit

Permalink
net: update docs on network interface API
Browse files Browse the repository at this point in the history
This change documents that the InterfaceAddrs function is less usable on
multi-homed IP nodes because of the lack of network interface
identification information.

Also updates documentation on exposed network interface API.

Fixes #14518.

Change-Id: I5e86606f8019ab475eb5d385bd797b052cba395d
Reviewed-on: https://go-review.googlesource.com/31371
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
cixtor committed Oct 18, 2016
1 parent 2a85578 commit 79c0362
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/net/interface.go
Expand Up @@ -69,7 +69,8 @@ func (f Flags) String() string {
return s
}

// Addrs returns interface addresses for a specific interface.
// Addrs returns a list of unicast interface addresses for a specific
// interface.
func (ifi *Interface) Addrs() ([]Addr, error) {
if ifi == nil {
return nil, &OpError{Op: "route", Net: "ip+net", Source: nil, Addr: nil, Err: errInvalidInterface}
Expand All @@ -81,8 +82,8 @@ func (ifi *Interface) Addrs() ([]Addr, error) {
return ifat, err
}

// MulticastAddrs returns multicast, joined group addresses for
// a specific interface.
// MulticastAddrs returns a list of multicast, joined group addresses
// for a specific interface.
func (ifi *Interface) MulticastAddrs() ([]Addr, error) {
if ifi == nil {
return nil, &OpError{Op: "route", Net: "ip+net", Source: nil, Addr: nil, Err: errInvalidInterface}
Expand All @@ -106,8 +107,11 @@ func Interfaces() ([]Interface, error) {
return ift, nil
}

// InterfaceAddrs returns a list of the system's network interface
// InterfaceAddrs returns a list of the system's unicast interface
// addresses.
//
// The returned list does not identify the associated interface; use
// Interfaces and Interface.Addrs for more detail.
func InterfaceAddrs() ([]Addr, error) {
ifat, err := interfaceAddrTable(nil)
if err != nil {
Expand Down

0 comments on commit 79c0362

Please sign in to comment.