Skip to content

Commit

Permalink
net: mark TestDialerDualStack as flaky
Browse files Browse the repository at this point in the history
It was already marked flaky for everything but the dashboard.
Remove that restriction. It's just flaky overall.

It's doing more harm than good.

Updates #13324

Change-Id: I36feff32a1b8681e77700f74b9c70cb4073268eb
Reviewed-on: https://go-review.googlesource.com/38459
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
  • Loading branch information
bradfitz committed Mar 23, 2017
1 parent b5e1ae4 commit c46226a
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/net/dial_test.go
Expand Up @@ -715,11 +715,8 @@ func TestDialerLocalAddr(t *testing.T) {
}

func TestDialerDualStack(t *testing.T) {
// This test is known to be flaky. Don't frighten regular
// users about it; only fail on the build dashboard.
if testenv.Builder() == "" {
testenv.SkipFlaky(t, 13324)
}
testenv.SkipFlaky(t, 13324)

if !supportsIPv4 || !supportsIPv6 {
t.Skip("both IPv4 and IPv6 are required")
}
Expand Down

0 comments on commit c46226a

Please sign in to comment.