cmd/vet: accidentally broken by "cmd/vet: switch to go/types from std repo" #10446
Comments
/cc @griesemer @robpike
I brought up such possibility during the review of CL 8767.
I think we should revert that CL and make a copy of modified cmd/vet into
the std repo.
Right now, even Go 1.4 users will no longer be able to install cmd/vet from
the tools
repo.
|
I can change ours so we checkout the sha before that was merged of tools, On Monday, April 13, 2015, Minux Ma notifications@github.com wrote:
Jessie Frazelle |
Can see this issue as well .. build broke |
Should be fixed now. Apologies. There was no intent to submit this in the first place; I blame a Fri night keyboarding malfunction... Please verify and let me know. Thanks. |
LGTM thanks |
thanks |
New to Go, does this mean I don't need to install |
@laike9m Please use the mailing list (golang-nuts@googlegroups.com) to ask questions. Please don't ask questions on closed issues. Thanks. The answer to your question is that for Go 1.4 you still need to go install golang.org/x/tools/cmd/vet. For Go 1.5 this may not be necessary. |
Hey so sorry if this is not the correct place for this. I tried IRC first but apparently its actually in the code, this was updated to only work with tip. And now its kinda messing up our CI :(
whomp whomp
The text was updated successfully, but these errors were encountered: