Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: accidentally broken by "cmd/vet: switch to go/types from std repo" #10446

Closed
jessfraz opened this issue Apr 14, 2015 · 8 comments

Comments

Projects
None yet
9 participants
@jessfraz
Copy link
Contributor

commented Apr 14, 2015

Hey so sorry if this is not the correct place for this. I tried IRC first but apparently its actually in the code, this was updated to only work with tip. And now its kinda messing up our CI :(
whomp whomp

Unrecognized import path "go/exact" (print.go:13:2)
Unrecognized import path "go/importer" (types.go:11:2)
Unrecognized import path "go/types" (main.go:18:2)
@minux

This comment has been minimized.

Copy link
Member

commented Apr 14, 2015

@jessfraz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

I can change ours so we checkout the sha before that was merged of tools,
might help if you all tag that sha as 1.4 or something for other people

On Monday, April 13, 2015, Minux Ma notifications@github.com wrote:

/cc @griesemer @robpike

I brought up such possibility during the review of CL 8767.
I think we should revert that CL and make a copy of modified cmd/vet into
the std repo.

Right now, even Go 1.4 users will no longer be able to install cmd/vet from
the tools
repo.


Reply to this email directly or view it on GitHub
#10446 (comment).

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

@harshavardhana

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2015

Can see this issue as well .. build broke

@griesemer

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2015

Should be fixed now. Apologies. There was no intent to submit this in the first place; I blame a Fri night keyboarding malfunction...

Please verify and let me know. Thanks.

@jessfraz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

LGTM thanks

@jessfraz jessfraz closed this Apr 14, 2015

@ahmetb

This comment has been minimized.

Copy link

commented Apr 14, 2015

thanks ❤️

@mikioh mikioh added the repo-tools label Apr 14, 2015

@mikioh mikioh changed the title go get golang.org/x/tools/cmd/vet is broken cmd/vet: accidentally broken by "cmd/vet: switch to go/types from std repo" Apr 14, 2015

@laike9m

This comment has been minimized.

Copy link

commented Apr 25, 2015

New to Go, does this mean I don't need to install cmd/vet if I'm using Go 1.4+?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2015

@laike9m Please use the mailing list (golang-nuts@googlegroups.com) to ask questions. Please don't ask questions on closed issues. Thanks.

The answer to your question is that for Go 1.4 you still need to go install golang.org/x/tools/cmd/vet. For Go 1.5 this may not be necessary.

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.