Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: redirect for old-style /#NNN links #11103

Closed
mikeyhill opened this issue Jun 6, 2015 · 5 comments
Closed

tour: redirect for old-style /#NNN links #11103

mikeyhill opened this issue Jun 6, 2015 · 5 comments

Comments

@mikeyhill
Copy link

Context: https://tour.golang.org/#1

Tour is blank in both FF and Chrome on osx. All plugins disabled (had adblock, ghostery, flash-control). Can't seem to view this tutorial. Let me know if you need more info.

@dominikh
Copy link
Member

dominikh commented Jun 6, 2015

Can confirm. JS error:

Error: Failed to execute 'replaceState' on 'History': A history state object with URL 'https://tour.golang.org1/' cannot be created in a document with origin 'https://tour.golang.org'. (script.js:507)
    at Error (native)
    at vc.f.url (https://tour.golang.org/script.js:477:28)
    at Ic.$get (https://tour.golang.org/script.js:506:6)
    at Object.d [as invoke] (https://tour.golang.org/script.js:473:127)
    at https://tour.golang.org/script.js:474:298
    at c (https://tour.golang.org/script.js:471:479)
    at Object.d [as invoke] (https://tour.golang.org/script.js:472:111)
    at https://tour.golang.org/script.js:474:298
    at c (https://tour.golang.org/script.js:471:479)
    at Object.d [as invoke] (https://tour.golang.org/script.js:472:111)

@minux
Copy link
Member

minux commented Jun 6, 2015 via email

@dominikh
Copy link
Member

dominikh commented Jun 6, 2015

I think there should be backwards-compatibility for those links. They've been used and shared for years to point to specific slides of the tour.

I understand that the numbering of slides might've changed, but then it should at least fall back gracefully, not break outright.

@minux minux changed the title tour: [short description of the issue] tour: redirect for old-style /#NNN links Jun 6, 2015
@minux minux added this to the Unreleased milestone Jun 6, 2015
@adg
Copy link
Contributor

adg commented Jun 8, 2015

@campoy we could pretty easily set up a map of old # fragments to their modern equivalents (or close enough). A blank page is bad, at least.

@gopherbot
Copy link

CL https://golang.org/cl/12775 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 5, 2016
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
Fixes golang/go#11103

Change-Id: Ib24ff2d7ae6ce46e1011c29234c02a76319bc743
Reviewed-on: https://go-review.googlesource.com/12775
Reviewed-by: Andrew Gerrand <adg@golang.org>
X-Tour-Commit: e7ac802432933530d235aa97b2c4fdef7a1e64fb
@rsc rsc unassigned campoy Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Fixes golang/go#11103

Change-Id: Ib24ff2d7ae6ce46e1011c29234c02a76319bc743
Reviewed-on: https://go-review.googlesource.com/12775
Reviewed-by: Andrew Gerrand <adg@golang.org>
X-Tour-Commit: e7ac802432933530d235aa97b2c4fdef7a1e64fb
KimuraDanaka119 added a commit to KimuraDanaka119/go-tour-jp that referenced this issue Jun 4, 2023
Fixes golang/go#11103

Change-Id: Ib24ff2d7ae6ce46e1011c29234c02a76319bc743
Reviewed-on: https://go-review.googlesource.com/12775
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants