New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/poly1305: Fails to build with Go1.3 on ARM, missing textflag.h #11448
Labels
Milestone
Comments
The new ARM code needs the same fix as https://golang.org/cl/154120043. |
This sounds like an easy task, shall I try it and submit a CL? |
Sure, thanks. |
Submitted as https://go-review.googlesource.com/12033 |
CL https://golang.org/cl/12033 mentions this issue. |
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 28, 2022
This is the same as https://golang.org/cl/154120043 Since the file textflag.h is not available on Go 1.3, the macros defined in textflag.h are replaced with their respective value. Fixes golang/go#11448 Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96 Reviewed-on: https://go-review.googlesource.com/12033 Reviewed-by: Ian Lance Taylor <iant@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
This is the same as https://golang.org/cl/154120043 Since the file textflag.h is not available on Go 1.3, the macros defined in textflag.h are replaced with their respective value. Fixes golang/go#11448 Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96 Reviewed-on: https://go-review.googlesource.com/12033 Reviewed-by: Ian Lance Taylor <iant@golang.org>
BiiChris
pushed a commit
to BiiChris/crypto
that referenced
this issue
Sep 15, 2023
This is the same as https://golang.org/cl/154120043 Since the file textflag.h is not available on Go 1.3, the macros defined in textflag.h are replaced with their respective value. Fixes golang/go#11448 Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96 Reviewed-on: https://go-review.googlesource.com/12033 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In golang/crypto@4d48e5f, an efficient ARM assembler implementation for poly1305 was added. Unfortunately, this assembler code includes
textflag.h
, which is not available in Go 1.3, so compiling fails for ARM:This issue is similar to #9211.
Is Go 1.3 not supported for the crypto package any more? Is it maybe possible to change the assembler code to not use
textflag.h
?The text was updated successfully, but these errors were encountered: