We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
// A Fetcher fetches URL paths for a single domain. type Fetcher struct { domain string events *trace.EventLog }
That * was not meant to be there, pointers to interfaces are rare.
*
func (f *Fetcher) Fetch(path string) (string, error) { resp, err := http.Get("http://" + domain + "/" + path)
undefined: domain, should be f.domain
undefined: domain
f.domain
func (f *Fetcher) Fetch(path string) (string, error) { ... if err != nil { f.events.Errorf("Get(%q) = %v", path, err) return }
Needs to be return "", err
return "", err
f.events.Printf("Get(%q) = %s", path, resp.Code)
It's spelled StatusCode, but resp.Status is probably best for that.
StatusCode
resp.Status
Also needs to return something, or have ... there.
...
Same missing return in Fetcher.Close, add a return nil.
Fetcher.Close
return nil
The text was updated successfully, but these errors were encountered:
@ianlancetaylor This does not seem to be my trace, it is some other trace. Or why am I assigned?
Sorry, something went wrong.
see #12364, we really need a mechanism to automatically assign issues to package owners.
CL https://golang.org/cl/14014 mentions this issue.
golang/net@ea47fc7
No branches or pull requests
That
*
was not meant to be there, pointers to interfaces are rare.undefined: domain
, should bef.domain
Needs to be
return "", err
It's spelled
StatusCode
, butresp.Status
is probably best for that.Also needs to return something, or have
...
there.Same missing return in
Fetcher.Close
, add areturn nil
.The text was updated successfully, but these errors were encountered: