Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: shard the shootout on builders #12623

Closed
bradfitz opened this issue Sep 15, 2015 · 3 comments
Closed

x/build: shard the shootout on builders #12623

bradfitz opened this issue Sep 15, 2015 · 3 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Sep 15, 2015

shard the shootout on builders, moving them into cmd/dist/test tasks

Also, disable on linux-arm and linux-arm-arm5. Maybe just compile only. Or run in some short mode.

They take way too long.

/cc @adg @davecheney

@bradfitz bradfitz added the Builders label Sep 15, 2015
@bradfitz bradfitz self-assigned this Sep 15, 2015
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Sep 15, 2015
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Sep 15, 2015

Turns out test/bench/shootout/timing.sh can already filter which tests it runs.

case $# in
0)
        run="fasta revcomp nbody binarytree fannkuch regexdna spectralnorm knucleotide mandelbrot meteor pidigits threadring chameneos"
        ;;
*)
        run=$*
esac

So test.go just needs to find that line and create sub-tests for each.

But later it'd be nice to rewrite that shell in Go, so it runs in more places.

And add a -fast flag to make it do fewer iterations (like 10 instead of 5000000), just to test coverage for the builders.

bradfitz added a commit to golang/build that referenced this issue Sep 15, 2015
…llows it

Also, don't run shootout on linux-arm (golang/go#12623)

Change-Id: I2c85b8a04917cb0992086012eaa59b00a6cb31a4
Reviewed-on: https://go-review.googlesource.com/14582
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Sep 18, 2015

Note: now that #12668 is fixed, the coordinator should un-blacklist the "shootout" tests for linux-arm.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 18, 2015

CL https://golang.org/cl/14738 mentions this issue.

@bradfitz bradfitz closed this in 1536c2e Sep 18, 2015
bradfitz added a commit to golang/build that referenced this issue Sep 18, 2015
The previous blacklisting was because of golang/go#12668, since fixed.

Further, the tests are now sharded (golang/go#12623) and this test
name doesn't even exist, so this change is a no-op.

Change-Id: Id141923e904a5aec91e53ba6f1d44e6cdf137cd2
Reviewed-on: https://go-review.googlesource.com/14773
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.