Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/pkcs12: typo in struct tag #13855

Closed
tipycalFlow opened this issue Jan 7, 2016 · 3 comments
Closed

x/crypto/pkcs12: typo in struct tag #13855

tipycalFlow opened this issue Jan 7, 2016 · 3 comments
Labels
FrozenDueToAge help wanted
Milestone
Go1.6Maybe

Comments

@tipycalFlow
Copy link

Hi,

I was trying to use the pkcs12 package's Decode method to read a .p12 file to further generate a TLS certificate and got the following error:
pkcs12: expected exactly two safe bags in the PFX PDU

I looked around the code in pkcs12.go and came across what seems to be a typing error. So my question is, should line 68:
Value asn1.RawValue 'ans1:"set"'
be:
Value asn1.RawValue 'asn1:"set"'
instead?

**I'm using go1.6beta1 darwin/amd64 on OS X Yosemite version 10.10.5 (14F1509)
@tipycalFlow tipycalFlow changed the title Probable typing error in pkcs12.go Typing error in pkcs12.go? Jan 7, 2016
@davecheney
Copy link
Contributor

@tipycalFlow this looks like a straight forward bug fix, do you want to take a go at fixing it, possibly including a test to make sure it doesn't regress ?

@davecheney davecheney added this to the Go1.6Maybe milestone Jan 7, 2016
@tipycalFlow
Copy link
Author

Actually, I'm not sure if this actually is a typo or it is intended as is. I just thought I'd bring it to the notice of the dev team

@bradfitz
Copy link
Contributor

bradfitz commented Jan 7, 2016

/cc @agl

@bradfitz bradfitz changed the title Typing error in pkcs12.go? x/crypto/pkcs12: typo in struct tag Jan 7, 2016
@tipycalFlow tipycalFlow mentioned this issue Jan 19, 2016
Closed
@golang golang locked and limited conversation to collaborators Jan 7, 2017
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@bradfitz
x/crypto/pkcs12: fix typo in struct tag
fed47d6 
No test, though, because I don't know this code. Sad that it passes
with the typo, though.

Fixes golang/go#13855

Change-Id: I1170baa0f94ae4b671f5ca654cb7dcc393d1cc4d
Reviewed-on: https://go-review.googlesource.com/18363
Reviewed-by: Adam Langley <agl@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@bradfitz
x/crypto/pkcs12: fix typo in struct tag
d6c1125 
No test, though, because I don't know this code. Sad that it passes
with the typo, though.

Fixes golang/go#13855

Change-Id: I1170baa0f94ae4b671f5ca654cb7dcc393d1cc4d
Reviewed-on: https://go-review.googlesource.com/18363
Reviewed-by: Adam Langley <agl@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@bradfitz
x/crypto/pkcs12: fix typo in struct tag
9c3c330 
No test, though, because I don't know this code. Sad that it passes
with the typo, though.

Fixes golang/go#13855

Change-Id: I1170baa0f94ae4b671f5ca654cb7dcc393d1cc4d
Reviewed-on: https://go-review.googlesource.com/18363
Reviewed-by: Adam Langley <agl@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@bradfitz
x/crypto/pkcs12: fix typo in struct tag
e667e67 
No test, though, because I don't know this code. Sad that it passes
with the typo, though.

Fixes golang/go#13855

Change-Id: I1170baa0f94ae4b671f5ca654cb7dcc393d1cc4d
Reviewed-on: https://go-review.googlesource.com/18363
Reviewed-by: Adam Langley <agl@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Go1.6Maybe
Development

No branches or pull requests
4 participants
@bradfitz @davecheney @tipycalFlow @gopherbot