cmd/compile: don't encode safemode bit in binary export format anymore

[griesemer]

The safemode bit is now in the file header. Space for the flag is still present but ignored (see bimport.go, bexport.go). Remove the encoding altogether.

[gopherbot]

CL https://golang.org/cl/23285 mentions this issue.

[mdempsky]

What's the rationale for leaving the safemode bit in 1.7's binary encoding? Just don't want to have to update go/internal/gcimporter and x/tools/go/gcimporter15 again?

[griesemer]

Yes - minimal change.

Fine to rip out with some larger change, but when we do that, there's a few
more cleanups that I want to do. Also, updating builtin.go is always a bit
tricky since we need to read it (old format) and then write it (new
format), and then update the compiler to read the new format.

• gri

On Fri, May 20, 2016 at 2:48 PM, Matthew Dempsky notifications@github.com
wrote:

What's the rationale for leaving the safemode bit in 1.7's binary
encoding? Just don't want to have to update go/internal/gcimporter
https://goto.google.com/internal/gcimporter and x/tools/go/gcimporter15
again?

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#15772 (comment)