Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: go1.7 release notes include typo for TLSConfig.NextProtos #16737

Closed
keegancsmith opened this issue Aug 16, 2016 · 2 comments
Closed

doc: go1.7 release notes include typo for TLSConfig.NextProtos #16737

keegancsmith opened this issue Aug 16, 2016 · 2 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.7.1

Comments

@keegancsmith
Copy link
Contributor

go/doc/go1.7.html

Line 912 in c6f19fe

or includes <code>"h2"</code> in its <code>TLSConfig.NextProto</code>.

The release notes state the field as TLSConfig.NextProto, but it should in fact be TLSConfig.NextProtos (note the trailing s).
@bradfitz bradfitz self-assigned this Aug 16, 2016
@bradfitz bradfitz added this to the Go1.7.1 milestone Aug 16, 2016
@bradfitz
Copy link
Contributor

Thanks. I sent https://go-review.googlesource.com/27126

We can cherry-pick it to the docs branch or 1.7 branch or something once it's in. I forget how that works.

@gopherbot
Copy link

CL https://golang.org/cl/27126 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 16, 2016
@bradfitz
doc/go1.7.html: fix name of tls.Config.NextProtos
496174e 
Updates #16737

Change-Id: Ia51fc9b06df43b7c6f7136e90b40362263c20081
Reviewed-on: https://go-review.googlesource.com/27126
Reviewed-by: Chris Broadfoot <cbro@golang.org>
gopherbot pushed a commit that referenced this issue Aug 17, 2016
@bradfitz @broady
[release-branch.go1.7] doc/go1.7.html: fix name of tls.Config.NextProtos
759c2c4 
Updates #16737

Change-Id: Ia51fc9b06df43b7c6f7136e90b40362263c20081
Reviewed-on: https://go-review.googlesource.com/27126
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Reviewed-on: https://go-review.googlesource.com/27234
@golang golang locked and limited conversation to collaborators Aug 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.7.1
Development

No branches or pull requests
3 participants
@bradfitz @keegancsmith @gopherbot