Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: remove a bunch of the /dl/ downloads #17574

Closed
bradfitz opened this issue Oct 24, 2016 · 11 comments
Closed

proposal: remove a bunch of the /dl/ downloads #17574

bradfitz opened this issue Oct 24, 2016 · 11 comments
Labels
FrozenDueToAge Proposal-Accepted Soon This needs to be done soon. (regressions, serious bugs, outages)

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 24, 2016 •
edited

https://golang.org/dl/ has grown a little large and crufty.

Is it important that you're able to see "go1.5.2" or "go1.5.1" in the list of available downloads? You should really be using Go 1.7. But if you must use Go 1.5, you should be using "go1.5.4", and not "go1.5.3" or earlier.

Let's remove all but the latest minor release of each.

People who need earlier versions can modify the URLs.

/cc @adg @broady @quentinmit @campoy
@bradfitz bradfitz added this to the Proposal milestone Oct 24, 2016
@broady
Copy link
Contributor

broady commented Oct 24, 2016 •
edited

If there are no objections, I can implement this.

Perhaps they should still be made accessible on that page - maybe in a dropdown? If people really do need the earlier point releases for any reason, they won't have access to the SHA hash (unless we populate the .sha256 files for older releases).

@bradfitz
Copy link
Contributor Author

All files should have a .sha256 file. Let's backfill those. I wasn't aware we had gaps.

@freeformz
Copy link

Just to be clear, this is just to remove the listings, not the actual files in google storage. Right?

@bradfitz
Copy link
Contributor Author

Yes. That's what I tried to imply with "People who need earlier versions can modify the URLs."

@minux
Copy link
Member

minux commented Oct 25, 2016 via email

@adg adg modified the milestones: Soon, Proposal Oct 31, 2016
@broady broady self-assigned this Dec 6, 2016
@gopherbot
Copy link

CL https://golang.org/cl/34824 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/34825 mentions this issue.

@broady
Copy link
Contributor

broady commented Jan 6, 2017

I don't plan on cherry-picking this to the 1.7 release branch. The changes will go live with 1.8.

gopherbot pushed a commit to golang/tools that referenced this issue Jan 6, 2017
@broady
godoc: allow nested toggles and toggles with <a name>
2d7295c 
Toggles can now be nested within one another. They can also be
referenced using an <a> element with the name attribute, rather than
an element with the "id" attribute.

Updates golang/go#17574.

Change-Id: I43c17499a6879e983a79a74e14c99128296288e1
Reviewed-on: https://go-review.googlesource.com/34825
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/34911 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Jan 6, 2017
@broady
godoc/dl: change "All versions" to "Archived versions"
8b89e95 
This change makes each release show only once on the whole page.
The current stable releases are not shown under the archive.

This change also fixes expandos to work correctly on IDs that are not
valid CSS selectors (i.e., "#go1.7.4") to ensure that the file listing
for a given version is expanded.

Updates golang/go#17574.

Change-Id: I7ff1041be3e0072286772ffa545a124764f81945
Reviewed-on: https://go-review.googlesource.com/34911
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/35094 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Jan 10, 2017
@broady
[release-branch.go1.7] godoc: allow nested toggles and toggles with <…
9d32829 
…a name>

Toggles can now be nested within one another. They can also be
referenced using an <a> element with the name attribute, rather than
an element with the "id" attribute.

Updates golang/go#17574.

Change-Id: I43c17499a6879e983a79a74e14c99128296288e1
Reviewed-on: https://go-review.googlesource.com/34825
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/35094
Reviewed-by: Chris Broadfoot <cbro@golang.org>
gopherbot pushed a commit to golang/tools that referenced this issue Jan 10, 2017
@broady
[release-branch.go1.7] godoc/dl: clean up display of stable versions
7771da7 
Under "Stable Versions", only show the latest minor versions of the most two
recent major versions.

Under each of those versions, move the downloads for primary ports to
the top of the table and the other downloads under a separate
"Other Ports" heading.

Add a listing for every stable Go version under "All versions",
collapsed by default.

Fixes golang/go#17574.
Updates golang/go#17018.

Change-Id: I7d74fef1b44a319a4bf65dedf24ffb27a7009f60
Reviewed-on: https://go-review.googlesource.com/34824
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/35095
Reviewed-by: Chris Broadfoot <cbro@golang.org>
gopherbot pushed a commit to golang/tools that referenced this issue Jan 10, 2017
@broady
[release-branch.go1.7] godoc/dl: change "All versions" to "Archived v…
ae17563 
…ersions"

This change makes each release show only once on the whole page.
The current stable releases are not shown under the archive.

This change also fixes expandos to work correctly on IDs that are not
valid CSS selectors (i.e., "#go1.7.4") to ensure that the file listing
for a given version is expanded.

Updates golang/go#17574.

Change-Id: I7ff1041be3e0072286772ffa545a124764f81945
Reviewed-on: https://go-review.googlesource.com/34911
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/35096
Reviewed-by: Chris Broadfoot <cbro@golang.org>
@broady
Copy link
Contributor

broady commented Jan 10, 2017

I cherry-picked them and I'm deploying to golang.org.

@golang golang locked and limited conversation to collaborators Jan 10, 2018
@bradfitz bradfitz added the Soon This needs to be done soon. (regressions, serious bugs, outages) label May 17, 2018
@rsc rsc unassigned broady Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal-Accepted Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@freeformz @bradfitz @broady @minux @adg @gopherbot