-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go get -insecure doesn't fallback to http #18179
Comments
Sorry, this isn't a regression from Go 1.7 to Go 1.8, so flagging for Go 1.9, since we're in a code freeze for the Go 1.8 release right now. |
I am not convinced this is incorrect behavior. -insecure means to try HTTP if HTTPS fails. HTTPS has not failed: it gave an authoritative answer (a 404 page with no <meta> tag). Is there a good reason for llvm.org to serve only a subset of its content via HTTPS? |
Possibly related, this also seems to break |
This appears to work for
|
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go1.7.4
What operating system and processor architecture are you using (
go env
)?darwin/amd64
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
go get -insecure -d -v llvm.org/llvm/bindings/go/llvm
doesn't download repo over http.What did you expect to see?
No errors. Package downloaded.
What did you see instead?
Apparently this change introduced this regression while fixing another edge case scenario. After analyzing the code a bit, I came to conclusion that it would be better to try the whole process of getting go-import meta tags via https and when it fails, retrying with http. Currently the code fails here after getting
err != nil
frommatchGoImport
. Only at this point (or earlier if error happens from one of the calls above) there should be switch to http, if insecure flag is given.The text was updated successfully, but these errors were encountered: