New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: order.go is outdated #18739

Open
josharian opened this Issue Jan 21, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@josharian
Contributor

josharian commented Jan 21, 2017

Many optimizations made in walk.go did not come with corresponding updates to order.go. For example, order.go makes a temporary for runtime calls for OCONVIFACE for many cases which walk special-cases not to make runtime calls. Another example is the introduction of temporaries for equality checks that walk inlines.

These do not impact correctness, but they might impact performance (if SSA cannot eliminate the pointless temporaries) and toolspeed (by generating useless nodes that then must be optimized away).

This issue is a reminder to investigate this, and decide whether it is worth the effort to modernize order.go.

cc @mdempsky

@josharian josharian added this to the Go1.9Maybe milestone Jan 21, 2017

@gopherbot

This comment has been minimized.

gopherbot commented Feb 2, 2017

CL https://golang.org/cl/36126 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 2, 2017

test: add extra test for issue18661
Make sure that the lack of an lvalue doesn't
cause extra side-effects.

Updates #18661
Updates #18739

Change-Id: I52eb4b4a5c6f8ff5cddd2115455f853c18112c19
Reviewed-on: https://go-review.googlesource.com/36126
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Maybe Jul 20, 2017

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 28, 2017

@bradfitz bradfitz modified the milestones: Go1.11, Unplanned May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment