Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Many optimizations made in walk.go did not come with corresponding updates to order.go. For example, order.go makes a temporary for runtime calls for OCONVIFACE for many cases which walk special-cases not to make runtime calls. Another example is the introduction of temporaries for equality checks that walk inlines.
These do not impact correctness, but they might impact performance (if SSA cannot eliminate the pointless temporaries) and toolspeed (by generating useless nodes that then must be optimized away).
This issue is a reminder to investigate this, and decide whether it is worth the effort to modernize order.go.
Make sure that the lack of an lvalue doesn't cause extra side-effects. Updates #18661 Updates #18739 Change-Id: I52eb4b4a5c6f8ff5cddd2115455f853c18112c19 Reviewed-on: https://go-review.googlesource.com/36126 Run-TryBot: Josh Bleecher Snyder <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Matthew Dempsky <email@example.com>