Many optimizations made in walk.go did not come with corresponding updates to order.go. For example, order.go makes a temporary for runtime calls for OCONVIFACE for many cases which walk special-cases not to make runtime calls. Another example is the introduction of temporaries for equality checks that walk inlines.
These do not impact correctness, but they might impact performance (if SSA cannot eliminate the pointless temporaries) and toolspeed (by generating useless nodes that then must be optimized away).
This issue is a reminder to investigate this, and decide whether it is worth the effort to modernize order.go.
Make sure that the lack of an lvalue doesn't
cause extra side-effects.
Run-TryBot: Josh Bleecher Snyder <firstname.lastname@example.org>
TryBot-Result: Gobot Gobot <email@example.com>
Reviewed-by: Matthew Dempsky <firstname.lastname@example.org>