You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many optimizations made in walk.go did not come with corresponding updates to order.go. For example, order.go makes a temporary for runtime calls for OCONVIFACE for many cases which walk special-cases not to make runtime calls. Another example is the introduction of temporaries for equality checks that walk inlines.
These do not impact correctness, but they might impact performance (if SSA cannot eliminate the pointless temporaries) and toolspeed (by generating useless nodes that then must be optimized away).
This issue is a reminder to investigate this, and decide whether it is worth the effort to modernize order.go.
Make sure that the lack of an lvalue doesn't
cause extra side-effects.
Updates #18661
Updates #18739
Change-Id: I52eb4b4a5c6f8ff5cddd2115455f853c18112c19
Reviewed-on: https://go-review.googlesource.com/36126
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Many optimizations made in walk.go did not come with corresponding updates to order.go. For example, order.go makes a temporary for runtime calls for OCONVIFACE for many cases which walk special-cases not to make runtime calls. Another example is the introduction of temporaries for equality checks that walk inlines.
These do not impact correctness, but they might impact performance (if SSA cannot eliminate the pointless temporaries) and toolspeed (by generating useless nodes that then must be optimized away).
This issue is a reminder to investigate this, and decide whether it is worth the effort to modernize order.go.
cc @mdempsky
The text was updated successfully, but these errors were encountered: