New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: support runtime poller with os.File on Solaris #19111

Open
ianlancetaylor opened this Issue Feb 15, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@ianlancetaylor
Contributor

ianlancetaylor commented Feb 15, 2017

The os test TestPipeThreads is failing on the Solaris builder, suggesting that for some reason os.File values are not working with the runtime poller. The code looks OK to me. I don't know why it is not working. Filing this issue to record the problem.

@ianlancetaylor ianlancetaylor added this to the Go1.9Maybe milestone Feb 15, 2017

@gopherbot

This comment has been minimized.

gopherbot commented Feb 15, 2017

CL https://golang.org/cl/37092 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 15, 2017

os: skip TestPipeThreads on Solaris
I don't know why it is not working.  Filed issue 19111 for this.

Fixes build.

Update #19111.

Change-Id: I76f8d6aafba5951da2f3ad7d10960419cca7dd1f
Reviewed-on: https://go-review.googlesource.com/37092
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@binarycrusader

This comment has been minimized.

Contributor

binarycrusader commented Feb 15, 2017

I haven't looked at the original change yet, but pipes are bi-directional on Solaris which tends to trip people up with things that "work" on Linux.

I don't know if this helps, but from pipe(2):

NOTES
Since a pipe is bi-directional, there are two separate flows of data.
Therefore, the size (st_size) returned by a call to fstat(2) with argu-
ment fildes[0] or fildes[1] is the number of bytes available for read-
ing from fildes[0] or fildes[1] respectively. Previously, the size
(st_size) returned by a call to fstat() with argument fildes[1] (the
write-end) was the number of bytes available for reading from fildes[0]
(the read-end).

When I get a moment, I'll see if I can figure something out.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 30, 2017

Too late for Go 1.10 probably.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 30, 2017

@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment