Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: MemStats docs reference non-existent XSys #19601

Closed
bradfitz opened this issue Mar 18, 2017 · 1 comment
Closed

runtime: MemStats docs reference non-existent XSys #19601

bradfitz opened this issue Mar 18, 2017 · 1 comment
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 18, 2017

The runtime MemStats type's Sys field says:

https://golang.org/pkg/runtime/#MemStats.Sys

   // Sys is the sum of the XSys fields below. Sys measures the
...

But there are no "XSys" fields anywhere in the Go tree.

$ git grep XSys
src/runtime/mstats.go:  // Sys is the sum of the XSys fields below. Sys measures the
src/syscall/mksyscall_windows.go:               pkgXSysWindows        // x/sys/windows package
src/syscall/mksyscall_windows.go:               pkgtype = pkgXSysWindows
src/syscall/mksyscall_windows.go:               case pkgXSysWindows:
src/syscall/mksyscall_windows.go:                       case pkgXSysWindows:

(nor case insensitively)

Noted while looking at #19600.

@bradfitz bradfitz added this to the Go1.9 milestone Mar 18, 2017
@bradfitz bradfitz changed the title runtime: MemStats docs reference non-existent XStats runtime: MemStats docs reference non-existent XSys Mar 18, 2017
@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Mar 18, 2017

Oh, ... StackSys, MSpanSys, etc. I get it. I shouldn't be filing bugs at this hour.

@bradfitz bradfitz closed this Mar 18, 2017
@golang golang locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.