New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: restore performance benchmarking dashboard #20552

Open
ianlancetaylor opened this Issue Jun 2, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@ianlancetaylor
Contributor

ianlancetaylor commented Jun 2, 2017

In a trybot run in https://storage.googleapis.com/go-build-log/dd2f2f0c/linux-amd64_19b3a9d1.log , after the build and the tests are complete, I see this:

##### 
iteration: 0
start-time: 2017-06-02T00:53:45Z
building testgo failed: exit status 1
can't load package: package .: no buildable Go source files in /tmp/workdir/go-parent

Error: tests failed: dist test failed: bench:bench-cmd-go.exe -test.bench . -test.benchmem -test.run ^$ -test.benchtime 100ms: exit status 2

@ianlancetaylor ianlancetaylor added this to the Go1.9 milestone Jun 2, 2017

@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented Jun 2, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jun 5, 2017

@quentinmit, this looks like the new benchmarks-on-trybot code having problems in some cases. Can you take a look?

@bradfitz bradfitz added the Builders label Jun 5, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jun 23, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jun 28, 2017

Trybot benchmarking was disabled, as announced on golang-dev, so pushing this to Go 1.10.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jun 28, 2017

@bradfitz bradfitz modified the milestones: Go1.10, Unreleased Nov 28, 2017

@bradfitz bradfitz changed the title from build: test flake running benchmarks to x/build: restore performance benchmarking dashboard Nov 28, 2017

@ysmolsky

This comment has been minimized.

Member

ysmolsky commented May 22, 2018

Part of the problem is that I cannot not figure out how to run trybots, etc builder services locally to tinker with it and being able to see results. In case of Playground I could run the whole thing in a docker.

@bradfitz, How does contributors to x/build run trybots locally?

@bradfitz

This comment has been minimized.

Member

bradfitz commented May 22, 2018

@ysmolsky, unfortunately the build system is not easy to hack on locally. It's possible, but pretty tedious and you need to be pretty aware of how it all works. Often times we do most of our testing in our dev+staging GCP project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment