Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
regexp: document that FindReaderIndex reads past the match in some cases #21883
What did you do?
What did you expect to see?
What did you see instead?
I remember reading somewhere in the godoc that the readers can eat the underlying runes to an arbitrarily degree, but it's not clear from the documentation for FindReaderIndex that this is possible.
I had to manually rewind the reader. This solution was not obvious at first, maybe a short addendum to the package function will clarify that it the function may skip matches.
Not sure there is anything that needs to be done.
There are two commonly used package scope functions (
The package documentation spans over 7 paragraphs, and introduces
It would be ideal for this caveat to be mentioned in the package scoped functions or made to be more apparent in the package documentation.