Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: failed to parse floating point constant on buffer boundary #21938

Closed
eliasnaur opened this issue Sep 19, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@eliasnaur
Copy link
Contributor

commented Sep 19, 2017

main.go.zip
Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +c100a0f668 Tue Sep 19 14:56:08 2017 +0000 linux/amd64

Does this issue reproduce with the latest release?

Don't know.

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/elias/dev/go:/home/elias/git/ui"
GORACE=""
main.go.zip

GOROOT="/home/elias/dev/go-tip"
GOTOOLDIR="/home/elias/dev/go-tip/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build857955865=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

go run main.go

What did you expect to see?

A successful run.

What did you see instead?

command-line-arguments

example/main.go:141:27: malformed constant: /5 (syntax error scanning number)

@mdempsky mdempsky self-assigned this Sep 19, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Sep 19, 2017

Change https://golang.org/cl/64830 mentions this issue: cmd/compile/internal/syntax: fix source buffer refilling

@mdempsky

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

Nice find, thanks!

@mdempsky mdempsky added this to the Go1.9.1 milestone Sep 20, 2017

@gopherbot gopherbot closed this in e06a64a Sep 20, 2017

@mdempsky mdempsky reopened this Sep 20, 2017

@mdempsky

This comment has been minimized.

Copy link
Member

commented Sep 20, 2017

Reopening for 1.9.x backport per discussion with @rsc and @griesemer.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

CL 64830 OK for Go 1.9.2.

@gopherbot

This comment has been minimized.

Copy link

commented Oct 15, 2017

Change https://golang.org/cl/70977 mentions this issue: [release-branch.go1.9] cmd/compile/internal/syntax: fix source buffer refilling

gopherbot pushed a commit that referenced this issue Oct 25, 2017

[release-branch.go1.9] cmd/compile/internal/syntax: fix source buffer…
… refilling

The previous code seems to have an off-by-1 in it somewhere, the
consequence being that we didn't properly preserve all of the old
buffer contents that we intended to.

After spending a while looking at the existing window-shifting logic,
I wasn't able to understand exactly how it was supposed to work or
where the issue was, so I rewrote it to be (at least IMO) more
obviously correct.

Fixes #21938.

Change-Id: I1ed7bbc1e1751a52ab5f7cf0411ae289586dc345
Reviewed-on: https://go-review.googlesource.com/64830
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-on: https://go-review.googlesource.com/70977
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2017

go1.9.2 has been packaged and includes:

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:09:15 UTC

@rsc rsc closed this Oct 26, 2017

@golang golang locked and limited conversation to collaborators Oct 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.