New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: correct stale links to specific line numbers to old versions of the code #22488
Comments
It took me a second to figure out what this bug is about. The blog post contains links to stuff like "[[http://golang.org/src/pkg/strings/strings.go?#L312]" which used to be correct in old versions of Go but no longer works. |
Regarding the proposed change from #L24 to #L22, I presume the link would be to the beginning of the godoc comment. |
Change https://golang.org/cl/86095 mentions this issue: |
@agnivade changing in the below L25 to L23 would link to the beginning of the comment
the other links in playground.article, pointing to lines in fd_nacl.go, point to the beginning of comments |
- Changed the links from go1.3 to master. - Removed trailing spaces from several lines. Fixes golang/go#22488 Change-Id: I41748fea956f0329eca0d520134670fa28618657 Reviewed-on: https://go-review.googlesource.com/86095 Reviewed-by: Andrew Bonventre <andybons@golang.org> Reviewed-by: Kevin Burke <kev@inburke.com> X-Blog-Commit: bd15c8473871452545ef270a25683cf10926362b
- Changed the links from go1.3 to master. - Removed trailing spaces from several lines. Fixes golang/go#22488 Change-Id: I41748fea956f0329eca0d520134670fa28618657 Reviewed-on: https://go-review.googlesource.com/86095 Reviewed-by: Andrew Bonventre <andybons@golang.org> Reviewed-by: Kevin Burke <kev@inburke.com> X-Blog-Commit: bd15c8473871452545ef270a25683cf10926362b
https://github.com/golang/blog/blob/master/content/godoc-documenting-go-code.article
If ?#L312 is updated to correspond with the current strings.go file, omitting the needless "?", I think that would be #L493.
https://github.com/golang/blog/blob/master/content/playground.article
Pending code review the developers might want to change #L24 to #L22.
The text was updated successfully, but these errors were encountered: