Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: correct stale links to specific line numbers to old versions of the code #22488

Closed
ghost opened this issue Oct 29, 2017 · 4 comments
Closed

Comments

@ghost
Copy link

ghost commented Oct 29, 2017

https://github.com/golang/blog/blob/master/content/godoc-documenting-go-code.article

If ?#L312 is updated to correspond with the current strings.go file, omitting the needless "?", I think that would be #L493.

https://github.com/golang/blog/blob/master/content/playground.article

Pending code review the developers might want to change #L24 to #L22.

@ghost ghost mentioned this issue Nov 3, 2017
@bradfitz bradfitz changed the title blog: modify files blog: correct stale links to specific line numbers to old versions of the code Nov 3, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Nov 3, 2017

It took me a second to figure out what this bug is about.

The blog post contains links to stuff like "[[http://golang.org/src/pkg/strings/strings.go?#L312]" which used to be correct in old versions of Go but no longer works.

@ghost
Copy link
Author

ghost commented Nov 3, 2017

Regarding the proposed change from #L24 to #L22, I presume the link would be to the beginning of the godoc comment.

@gopherbot
Copy link

Change https://golang.org/cl/86095 mentions this issue: content: fix stale links to line numbers

@ghost
Copy link
Author

ghost commented Jan 7, 2018

@agnivade changing in the below L25 to L23 would link to the beginning of the comment

@@ -228,17 +228,17 @@
 	}
 
 File descriptors are tracked by a global slice named
-[[https://github.com/golang/go/blob/go1.3/src/pkg/syscall/fd_nacl.go#L16][`files`]].
-Each file descriptor corresponds to a [[https://github.com/golang/go/blob/go1.3/src/pkg/syscall/fd_nacl.go#L24][`file`]]
-and each `file` provides a value that implements the [[https://github.com/golang/go/blob/go1.3/src/pkg/syscall/fd_nacl.go#L29][`fileImpl`]] interface.
+[[https://github.com/golang/go/blob/master/src/syscall/fd_nacl.go#L17][`files`]].
+Each file descriptor corresponds to a [[https://github.com/golang/go/blob/master/src/syscall/fd_nacl.go#L25][`file`]]
+and each `file` provides a value that implements the [[https://github.com/golang/go/blob/master/src/syscall/fd_nacl.go#L30][`fileImpl`]] interface.
 There are several implementations of the interface:

the other links in playground.article, pointing to lines in fd_nacl.go, point to the beginning of comments

@golang golang locked and limited conversation to collaborators Jan 8, 2019
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
- Changed the links from go1.3 to master.
- Removed trailing spaces from several lines.

Fixes golang/go#22488

Change-Id: I41748fea956f0329eca0d520134670fa28618657
Reviewed-on: https://go-review.googlesource.com/86095
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
X-Blog-Commit: bd15c8473871452545ef270a25683cf10926362b
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
- Changed the links from go1.3 to master.
- Removed trailing spaces from several lines.

Fixes golang/go#22488

Change-Id: I41748fea956f0329eca0d520134670fa28618657
Reviewed-on: https://go-review.googlesource.com/86095
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
X-Blog-Commit: bd15c8473871452545ef270a25683cf10926362b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants