Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Go 1.9.3 release status #23477

Closed
andybons opened this issue Jan 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@andybons
Copy link
Member

commented Jan 18, 2018

Go 1.9.3 release status

PROBLEMS WITH RELEASE

  • CL 88715: bad Gerrit status: MERGED (not NEW)
  • CL 88676: bad Gerrit status: MERGED (not NEW)
  • CL 88635: bad Gerrit status: MERGED (not NEW)
  • CL 88535: bad Gerrit status: MERGED (not NEW)
  • CL 88495: bad Gerrit status: MERGED (not NEW)
  • CL 88316: bad Gerrit status: MERGED (not NEW)
  • CL 88315: bad Gerrit status: MERGED (not NEW)
  • CL 77331: bad Gerrit status: MERGED (not NEW)

Issues with fixes

  • #20427 runtime: memory corruption crashes with os/exec on Linux kernel 4.4
    • CL 88495 per andybons; [release-branch.go1.9] runtime: call amd64 VDSO entry points on large stack
  • #21655 cmd/compile: "offset too large" error
    • CL 82675 per andybons; cmd/compile: fix large load/store offsets on 386
  • #22429 cmd/compile: invalid instruction error for FMOVD when compiling for 387
    • CL 73551 per andybons; cmd/compile: make sure not to use SP as an index register
  • #22458 cmd/compile: runtime.KeepAlive doesn't work
    • CL 74210 per andybons; cmd/compile: fix runtime.KeepAlive
  • #22683 cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop
    • CL 77331 per andybons; [release-branch.go1.9] cmd/compile: fix decomposition of 1-element arrays
  • #22725 runtime: reported CPU time of STW phases is low
    • CL 77710 per andybons; runtime: fix gctrace STW CPU time and CPU fraction
  • #22781 runtime: fatal error: sweep increased allocation count, go1.9.x
    • CL 88635 per andybons; [release-branch.go1.9] cmd/compile: fix mapassign_fast* routines for pointer keys
  • #22842 math/big: r.Exp(x, 1, m) wrong if r is initially non-zero [Go1.9]
    • CL 78995 per andybons; math/big: protect against aliasing in nat.divLarge
  • #22930 runtime: crash with C sigaltstacks
    • CL 88315 per andybons; [release-branch.go1.9] runtime: restore the Go-allocated signal stack in unminit
    • CL 88316 per andybons; [release-branch.go1.9] runtime: use MAP_ANON in sigstack check
  • #22976 database/sql: transaction leak
    • CL 81736 per andybons; database/sql: fix transaction leak
  • #23066 net/http: backport invalid memory address or nil pointer dereference fix?
    • CL 88676 per andybons; [release-branch.go1.9] net/http: update bundled http2
  • #23392 net/url: Parse accepts invalid userinfo strings
    • CL 88535 per andybons; [release-branch.go1.9] net/url: reject invalid userinfo values when parsing URLs
  • #23490 doc: document Go 1.9.3
    • CL 88536 per andybons; doc: document Go 1.9.3
  • #23491 doc: change anchor URLs from golang.org/dl/ to /dl/
    • CL 88715 per andybons; [release-branch.go1.9] doc: change anchor URLs from golang.org/dl/ to /dl/

Changes on release branch

  • CL missing for cherry-pick of CL 73551 (for #22429)
    • cmd/compile: make sure not to use SP as an index register
  • CL missing for cherry-pick of CL 74210 (for #22458)
    • cmd/compile: fix runtime.KeepAlive
  • CL missing for cherry-pick of CL 77331 (for #22683)
    • [release-branch.go1.9] cmd/compile: fix decomposition of 1-element arrays
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 77710 (for #22725)
    • runtime: fix gctrace STW CPU time and CPU fraction
  • CL missing for cherry-pick of CL 78995 (for #22842)
    • math/big: protect against aliasing in nat.divLarge
  • CL missing for cherry-pick of CL 81736 (for #22976)
    • database/sql: fix transaction leak
  • CL missing for cherry-pick of CL 82675 (for #21655)
    • cmd/compile: fix large load/store offsets on 386
  • CL missing for cherry-pick of CL 88315 (for #22930)
    • [release-branch.go1.9] runtime: restore the Go-allocated signal stack in unminit
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88316 (for #22930)
    • [release-branch.go1.9] runtime: use MAP_ANON in sigstack check
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88495 (for #20427)
    • [release-branch.go1.9] runtime: call amd64 VDSO entry points on large stack
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88535 (for #23392)
    • [release-branch.go1.9] net/url: reject invalid userinfo values when parsing URLs
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88536 (for #23490)
    • doc: document Go 1.9.3
  • CL missing for cherry-pick of CL 88635 (for #22781)
    • [release-branch.go1.9] cmd/compile: fix mapassign_fast* routines for pointer keys
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88676 (for #23066)
    • [release-branch.go1.9] net/http: update bundled http2
    • ERROR: bad Gerrit status: MERGED (not NEW)
  • CL missing for cherry-pick of CL 88715 (for #23491)
    • [release-branch.go1.9] doc: change anchor URLs from golang.org/dl/ to /dl/
    • ERROR: bad Gerrit status: MERGED (not NEW)

Log

2018/01/22 16:02:42 starting
2018/01/22 16:02:42 working in /usr/local/google/home/andybons/go-releasebot-work/go1.9.3
2018/01/22 16:02:42 $ git fetch origin master
2018/01/22 16:02:43 $ git fetch origin release-branch.go1.9
2018/01/22 16:02:45 $ git clone --reference /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitmirror -b release-branch.go1.9 https://go.googlesource.com/go /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitwork
2018/01/22 16:02:49 $ git codereview change relwork
2018/01/22 16:02:50 $ git config gc.auto 0
2018/01/22 16:02:50 $ git rev-parse go1.9.3
2018/01/22 16:02:53 $ git rev-parse go1.9.3

— golang.org/x/build/cmd/releasebot, Jan 22 21:03:03 UTC

@andybons andybons added this to the Go1.9.3 milestone Jan 18, 2018

@andybons

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2018

go1.9.3 has been packaged and includes:

  • CL 73551 cmd/compile: make sure not to use SP as an index register
  • CL 74210 cmd/compile: fix runtime.KeepAlive
  • CL 77331 [release-branch.go1.9] cmd/compile: fix decomposition of 1-element arrays
  • CL 77710 runtime: fix gctrace STW CPU time and CPU fraction
  • CL 78995 math/big: protect against aliasing in nat.divLarge
  • CL 81736 database/sql: fix transaction leak
  • CL 82675 cmd/compile: fix large load/store offsets on 386
  • CL 88315 [release-branch.go1.9] runtime: restore the Go-allocated signal stack in unminit
  • CL 88316 [release-branch.go1.9] runtime: use MAP_ANON in sigstack check
  • CL 88495 [release-branch.go1.9] runtime: call amd64 VDSO entry points on large stack
  • CL 88535 [release-branch.go1.9] net/url: reject invalid userinfo values when parsing URLs
  • CL 88536 doc: document Go 1.9.3
  • CL 88635 [release-branch.go1.9] cmd/compile: fix mapassign_fast* routines for pointer keys
  • CL 88676 [release-branch.go1.9] net/http: update bundled http2
  • CL 88715 [release-branch.go1.9] doc: change anchor URLs from golang.org/dl/ to /dl/

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Jan 22 21:03:00 UTC

@andybons andybons closed this Jan 22, 2018

@golang golang locked and limited conversation to collaborators Jan 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.