x/crypto/openpgp: Encrypt() is missing the compression part

[gprggr]

What version of Go are you using (go version)?

go 1.10.1

openpgp.Encrypt(...) is missing the compression part. I fixed it for me by taking a piece of code from
openpgp.SymmetricallyEncrypt(...) beginning at line 123.

diff write.go.old write.go
write.go.diff.txt

[agnivade]

/cc @FiloSottile @agl

[byxiangfei]

found this issue, too. Go version 1.12

[FiloSottile]

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.

If this is a security issue, please email security@golang.org and we will assess it and provide a fix.

If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.

If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.