Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/app/appengine: build dashboard broken #26115

Closed
bradfitz opened this issue Jun 28, 2018 · 2 comments
Closed

x/build/app/appengine: build dashboard broken #26115

bradfitz opened this issue Jun 28, 2018 · 2 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jun 28, 2018

Looks like I broke the App Engine app with https://go-review.googlesource.com/99016

[/home/bradfitz/.config/gcloud/logs/2018.06.28/20.25.30.149062.log].
╔════════════════════════════════════════════════════════════╗
╠═ Uploading 146 files to Google Cloud Storage              ═╣
╚════════════════════════════════════════════════════════════╝
File upload done.
Updating service [default]...failed.                                                                                                                     
ERROR: (gcloud.app.deploy) Error Response: [9] Deployment contains files that cannot be compiled: Compile failed:
/work_dir/config.go:75: cannot use func literal (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/handler.go:126: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/handler.go:500: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/handler.go:627: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/handler.go:676: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/handler.go:873: cannot use func literal (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/perf_learn.go:150: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
/work_dir/update.go:113: cannot use tx (type func("context".Context) error) as type func("golang.org/x/net/context".Context) error in argument to "google.golang.org/appengine/datastore".RunInTransaction
2018/06/28 13:25:52 go-app-builder: build timing: 24×compile (6.237s total), 0×link (0s total)
2018/06/28 13:25:52 go-app-builder: failed running compile: exit status 2

/cc @hyangah @andybons

@bradfitz bradfitz added the NeedsFix label Jun 28, 2018
@bradfitz bradfitz self-assigned this Jun 28, 2018
@gopherbot gopherbot added this to the Unreleased milestone Jun 28, 2018
@gopherbot gopherbot added the Builders label Jun 28, 2018
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 28, 2018

Yes, our app.yaml has:

bradfitz@gdev:~/src/golang.org/x/build/app$ cat appengine/app.yaml 
runtime: go
api_version: go1.8

And type aliases (which fixes this problem) weren't added until Go 1.9.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 28, 2018

Change https://golang.org/cl/121418 mentions this issue: app/appengine: update to Go 1.9 so we can use std context

@golang golang locked and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.