Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add more verbose comments in Caller method #26437

Closed
minaevmike opened this issue Jul 18, 2018 · 4 comments
Closed

runtime: add more verbose comments in Caller method #26437

minaevmike opened this issue Jul 18, 2018 · 4 comments

Comments

@minaevmike
Copy link
Contributor

@minaevmike minaevmike commented Jul 18, 2018

https://github.com/golang/go/blob/master/src/runtime/extern.go#L179
1+skip-1 makes no sense, i think i can be converted to skip or some comments can be added to discribe why we make +1-1.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 18, 2018

For the record, the -1 was added in https://golang.org/cl/4810054, when the code was changed to ask for two PC values. At this point we should probably just drop it.

@wingyplus

This comment has been minimized.

Copy link
Contributor

@wingyplus wingyplus commented Jul 18, 2018

So we can remove +1-1 in L179. Am I right?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 18, 2018

Yes.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 19, 2018

Change https://golang.org/cl/124895 mentions this issue: runtime: remove +1-1 when asking PC values

@bradfitz bradfitz modified the milestones: Unplanned, Go1.12 Jul 19, 2018
@gopherbot gopherbot closed this in 68527ff Aug 22, 2018
@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.