Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
encoding/gob: tooBig is too small #27635
What version of Go are you using (
This was first introduced in 9c3fc83, because earlier it was easy to get
My initial reaction would be "we can just bump this limit on 64-bit", or "we can just use 64-bit sized integers in the encoder and decoder", although I don't know the internals of the gob package that well.
The original issue was #8084. Interestingly enough, it happened on amd64.
I guess it's fine to double the limit while we don't have a better long-term solution, but I'll leave that to Rob to decide.
@mvdan thanks for your input. I tried to looking through the gob source but I can't really make out what kind of integers are used.
But what I can tell you is that I changed the data structure from
16 similar comments
22 similar comments
Indeed. I kept an eye on gopherbot logs (among other builder-related services that touch GitHub) during the GitHub semi-outage, and didn't spot it doing anything visibly bad. (See #28320 for what I did find, but it's unrelated to this.)
Gopherbot determines if it has acted by looking if its comment already exists on an issue, so if GitHub reports the comment as not being there (as was the case), it can't help but think it hasn't acted yet and repeat the action. In other words, it relies on GitHub working.
GitHub does offer a status API. If we really had to take action, we could add code that pauses gopherbot when https://status.github.com/api reports that GitHub is in poor state. But as far as I can see, gopherbot didn't do anything too outrageous and so we don't have to do that.