Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: failure parsing go.mod silently ignored #28520

Open
heschi opened this issue Oct 31, 2018 · 1 comment
Open

x/tools/go/packages: failure parsing go.mod silently ignored #28520

heschi opened this issue Oct 31, 2018 · 1 comment
Labels
modules Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Oct 31, 2018

Followup from #28518.

We spent a while chasing our tails before realizing that go list was failing entirely. I think the error was swallowed because the call fell into the usesExportData case of invokeGo's error handling. Can anything better be done?

@ianthehat @matloob
@gopherbot gopherbot added this to the Unreleased milestone Oct 31, 2018
@myitcv
Copy link
Member

myitcv commented Oct 31, 2018

I just commented over in #28518 (comment)

@bcmills bcmills added the modules label Nov 9, 2018
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
modules Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@myitcv @bcmills @gopherbot @heschi