Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: failure parsing go.mod silently ignored #28520

Open
heschik opened this issue Oct 31, 2018 · 1 comment
Open

x/tools/go/packages: failure parsing go.mod silently ignored #28520

heschik opened this issue Oct 31, 2018 · 1 comment
Labels
Milestone

Comments

@heschik
Copy link
Contributor

@heschik heschik commented Oct 31, 2018

Followup from #28518.

We spent a while chasing our tails before realizing that go list was failing entirely. I think the error was swallowed because the call fell into the usesExportData case of invokeGo's error handling. Can anything better be done?

@ianthehat @matloob

@gopherbot gopherbot added this to the Unreleased milestone Oct 31, 2018
@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Oct 31, 2018

I just commented over in #28518 (comment)

@bcmills bcmills added the modules label Nov 9, 2018
@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.