Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/devapp/owners: add owners for less-common GOOS and GOARCHes #28596
https://dev.golang.org/owners/ currently lists owners for code components.
However, some issues seem to be specific to a particular GOOS or GOARCH, and in order to diagnose those issues it's helpful to get input from someone with platform-specific expertise (@alexbrainman, @mundaym, @ceseo, @0intro, @neelance, and surely others I'm forgetting).
I've learned a few of those platform-to-expert mappings, but it would be helpful to codify them more explicitly. Can we put them in
Or we could just add owners for the GOARCH directories:
But for GOOS, we don't really have directories in general. We just have lots of +build files for runtime & syscall, etc. So maybe we do need an explicit mechanism to record these.
In the meantime I can often find owners by looking at https://farmer.golang.org/builders but that's not quite sufficient.
GOARCH directories seem like the logical place for that.
Perhaps we could list GOOS owners as owners under
I prototyped the idea of using the owner data from x/build/dashboard described above. /cc @jayconrod
It was informative to try it, but I don't think we can proceed with that approach. According to golang.org/wiki/PortingPolicy:
The data in x/build/dashboard corresponds to builder owners, not necessarily the port owners.
I think we need to make a new manually-curated table in owners and start adding people to it, getting their consent in the process. We should make adding a port owner to the table a part of https://github.com/golang/go/wiki/PortingPolicy#requirements-for-a-new-port for future ports.