Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.11] #29235

Closed
FiloSottile opened this issue Dec 13, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@FiloSottile
Copy link
Member

commented Dec 13, 2018

This is a tracking issue for #29231, a security vulnerability fixed in Go 1.11.3.

@FiloSottile FiloSottile added this to the Go1.11.3 milestone Dec 13, 2018

@FiloSottile FiloSottile changed the title cmd/go: directory traversal via curly braces in import paths [Go 1.11] cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.11] Dec 13, 2018

@tomislavmitic2012

This comment has been minimized.

Copy link

commented Dec 14, 2018

@FiloSottile You have just broken every one that uses packages such as gobuffalo/pop/ which were gotten previously with go get github.com/gobuffalo/pop/... the only way to fix it is to downgrade to go 1.11.2. How go you suggest we proceed.

@tomislavmitic2012

This comment has been minimized.

Copy link

commented Dec 14, 2018

Breaking change is here, this totally needs to be reverted 8954add#diff-5b11f198c631a3d489e1be171853ab7bR40

@FiloSottile

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

We know it's broken, see #29241. You can run go get -d github.com/gobuffalo/pop && go get github.com/gobuffalo/pop/... instead for now. We are not reverting a security fix, but will fix the regression in the upcoming minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.