Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: custom UnmarshalTypeError no longer has struct context [1.11 backport] #29364

Closed
gopherbot opened this issue Dec 20, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@gopherbot
Copy link

commented Dec 20, 2018

@mvdan requested issue #27464 to be considered for backport to the next 1.11 minor release.

@gopherbot please backport to 1.11.

@mvdan

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

@bradfitz It looks like I can't create the cherry-pick CL for 1.11, as that requires the forge-author permission.

Do we want to ask the original author to do it, or can you do it?

@gopherbot

This comment has been minimized.

Copy link
Author

commented Dec 20, 2018

Change https://golang.org/cl/155377 mentions this issue: [release-branch.go1.11] encoding/json: recover saved error context when unmarshalling

gopherbot pushed a commit that referenced this issue Jan 3, 2019

[release-branch.go1.11] encoding/json: recover saved error context wh…
…en unmarshalling

Fixes #29364

Change-Id: I270c56fd0d5ae8787a1293029aff3072f4f52f33
Reviewed-on: https://go-review.googlesource.com/132955
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 22afb35)
Reviewed-on: https://go-review.googlesource.com/c/155377
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link
Author

commented Jan 3, 2019

Closed by merging 61b8817 to release-branch.go1.11.

@gopherbot gopherbot closed this Jan 3, 2019

@julieqiu julieqiu modified the milestones: Go1.11.5, Go1.11.6 Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.