Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: add implementation of Diffie-Hellman x448 #29390

Open
armfazh opened this issue Dec 22, 2018 · 3 comments
Open

x/crypto: add implementation of Diffie-Hellman x448 #29390

armfazh opened this issue Dec 22, 2018 · 3 comments
Milestone

Comments

@armfazh
Copy link

@armfazh armfazh commented Dec 22, 2018

Feature request: implementation of X25519 and X448.
The X25519 function is provided by x/crypto/curve25519 package, but not for X448.

@gopherbot gopherbot added this to the Unreleased milestone Dec 22, 2018
@armfazh armfazh changed the title x/crypto diffie-hellman x448 x/crypto Diffie-Hellman x448 Dec 22, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Dec 22, 2018

Change https://golang.org/cl/155717 mentions this issue: x/crypto: Adds Fp25519/448 and X25519/X448 for amd64 arch

@ALTree ALTree changed the title x/crypto Diffie-Hellman x448 x/crypto: add implementation of Diffie-Hellman x448 Dec 22, 2018
@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Jan 29, 2019

We went without X448 for a long time now, so it's not clear we need it in x/crypto, and it's a lot of manually written assembly to review and maintain. Before accepting this I would want to hear who needs it and why.

@KBassford

This comment has been minimized.

Copy link

@KBassford KBassford commented Dec 11, 2019

Due to RFC 7748 (https://tools.ietf.org/html/rfc7748) being adopted by the US government, should be more than enough justification. Dependent Modules (such as ECDH, which is what brought me here) will also require updating. As noted above, the cloudflare module has already been updated.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.