Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: teach prove that x ∈ [0, c) ⇒ c - x ∈ [0, c) #29477

Closed
josharian opened this issue Dec 31, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@josharian
Copy link
Contributor

commented Dec 31, 2018

Consider:

package p

func f(x int64, s uint) int64 {
	s1 := s & 63
	s2 := 64 - s1
	return x >> s2
}

(Extracted from code that does multi-word shifts.)

The compiler should be able to prove that s2 ∈ [0, 64), and thus emit a plain shift, rather than a shift + mask. It does not.

cc @rasky @aclements

@josharian josharian added this to the Unplanned milestone Dec 31, 2018

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018

Except that that is not sound. Time for bed.

@josharian josharian closed this Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.