Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/get_(unicode|dotfiles|brace) failing on Plan 9 #29640

Closed
0intro opened this issue Jan 9, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@0intro
Copy link
Member

commented Jan 9, 2019

TestScript/get_unicode, TestScript/get_dotfiles and TestScript/get_brace are failing on Plan 9 (when git is available in the path), because they expect a full-featured Git command, while on Plan 9, the git tool has been emulated as a simple rc script.

--- FAIL: TestScript/get_unicode (0.01s)
    --- FAIL:  (1.85s)
        script_test.go:183: 
            # Construct a repository that imports a non-ASCII path. (1.657s)
            > cd $WORK/_origin/example.com/unicode
            $WORK/_origin/example.com/unicode
            > exec git init
            [stderr]
            usage: git <command> [<args>]
            [exit status: 'git 1643000: usage']
            FAIL: testdata/script/get_unicode.txt:5: unexpected command failure
            
    --- FAIL: TestScript/get_dotfiles (1.68s)
        script_test.go:183: 
            # Set up a benign repository and a repository with a dotfile name. (1.655s)
            > cd $WORK/_origin/foo
            $WORK/_origin/foo
            > exec git init
            [stderr]
            usage: git <command> [<args>]
            [exit status: 'git 1643038: usage']
            FAIL: testdata/script/get_dotfiles.txt:5: unexpected command failure
            
    --- FAIL: TestScript/get_brace (1.66s)
        script_test.go:183: 
            # Set up some empty repositories. (1.644s)
            > cd $WORK/_origin/foo
            $WORK/_origin/foo
            > exec git init
            [stderr]
            usage: git <command> [<args>]
            [exit status: 'git 1643043: usage']
            FAIL: testdata/script/get_brace.txt:5: unexpected command failure
            
FAIL

@0intro 0intro added the OS-Plan9 label Jan 9, 2019

@0intro 0intro added this to the Go1.12 milestone Jan 9, 2019

@0intro 0intro self-assigned this Jan 9, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Jan 9, 2019

Change https://golang.org/cl/157119 mentions this issue: cmd/go: skip tests using Git on Plan 9

@gopherbot gopherbot closed this in 9a5a504 Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.