Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptesting: unexpected top level test output belonging to a subtest #29755
Comments
mfridman
changed the title
testing: unexpected outer test output belonging to a subtest
testing: unexpected top level test output belonging to a subtest
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
CC @mpvl @josharian As far as I can tell the intentation looks right. I suspect a |
bcmills
added
the
NeedsInvestigation
label
Jan 29, 2019
bcmills
added this to the Go1.13 milestone
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mfridman commentedJan 15, 2019
•
edited
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
N/A, working with master.
What operating system and processor architecture are you using (
go env
)?What did you do?
Run code from this playground example
What did you expect to see?
Expected to see the test output
some_test.go:14: woah, something went wrong
belong to the top level test and not the inner subtest. E.g., when running the above with
-json
I'd expect this output:note the test name in the json output is expected to be
TestThis/topLevelTest
What did you see instead?
Instead the output and
-json
output makes it seem as if it belongs to the inner subtest, i.e., test nameTestThis/topLevelTest/subA
This may be a misuse of the API, but I couldn't find any docs that mention there shouldn't be anything in between subtests.
The -json output was:
This might be an issue with test2json.