Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: deprecate or delete it? (not trolling) #33215

Closed
karalabe opened this issue Jul 22, 2019 · 2 comments
Closed

x/net/websocket: deprecate or delete it? (not trolling) #33215

karalabe opened this issue Jul 22, 2019 · 2 comments
Milestone

Comments

@karalabe
Copy link
Contributor

@karalabe karalabe commented Jul 22, 2019

We've been using the golang.org/x/net/websocket package for a long time, mostly because I trust an "official" library more than an alternative. The "official" package does warn that:

This package currently lacks some features found in an alternative and more actively maintained WebSocket package.

Unfortunately this is only half the truth. The full truth is, that due to the missing features, connections between the package and a proper implementation will often break.

My point really being here is that the "official" websocket package is not simply missing some features, rather those features will lead to serious - and hard to debug - issues down the line. As I see it, x/net/websocket is not going to be brought up to spec with websocket proper, and there are better alternatives.

Could we deprecate the package? Ideally I'd just delete it, but that's probably too drastic and would break dependent code.

@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2019
@agnivade
Copy link
Contributor

@agnivade agnivade commented Jul 22, 2019

Thanks. I am going to mark this as a duplicate of #18152. It talks about the exact same issue and already has a lot of context. Let us continue the conversation there.

@agnivade agnivade closed this Jul 22, 2019
@karalabe
Copy link
Contributor Author

@karalabe karalabe commented Jul 22, 2019

👍

@golang golang locked and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.