Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/mod_symlink flaked on OpenBSD #35351

Open
FiloSottile opened this issue Nov 4, 2019 · 4 comments

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Nov 4, 2019

https://storage.googleapis.com/go-build-log/dc9d7491/openbsd-amd64-64_ba01c5e0.log from the https://golang.org/cl/205058 TryBot.

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_symlink (0.13s)
        script_test.go:192: 
            # 'go list' should resolve modules of imported packages. (0.114s)
            > go list -deps -f '{{.Module}}' .
            [stdout]
            <nil>
            golang.org/issue/28107
            [stderr]
            go: downloading golang.org/x/text v0.3.0
            > stdout golang.org/x/text
            FAIL: testdata/script/mod_symlink.txt:6: no match for `(?m)golang.org/x/text` found in stdout

No hits on greplogs. /cc @bcmills

@FiloSottile FiloSottile added this to the Go1.14 milestone Nov 4, 2019
@FiloSottile

This comment has been minimized.

Copy link
Member Author

@FiloSottile FiloSottile commented Nov 4, 2019

Saw another TestScript flake on OpenBSD. Might be unrelated but they are both generic enough that I think we can start by tracking them together.

https://storage.googleapis.com/go-build-log/e4992e62/openbsd-amd64-64_822845d2.log

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_sumdb_proxy (0.04s)
        script_test.go:192: 
            # basic fetch (through proxy) works (0.041s)
            > cp go.mod.orig go.mod
            > go get -d rsc.io/fortune@v1.0.0 # note: must use test proxy, does not exist in real world
            [stderr]
            go get rsc.io/fortune@v1.0.0: rsc.io/fortune@v1.0.0: Get "http://127.0.0.1:4969/mod/rsc.io/fortune/@v/v1.0.0.info": dial tcp 127.0.0.1:4969: bad file descriptor
            [exit status 1]
            FAIL: testdata/script/mod_sumdb_proxy.txt:8: unexpected command failure
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Nov 5, 2019

I'm not sure where that first failure came from, but the second looks like #35045, which makes me suspect some lingering netpoll breakage (CC @ianlancetaylor).

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 5, 2019

I can't figure out what sources were used for the openbsd failure. The log says openbsd-amd64-64 at e4992e62bd450927e94469a0422c516d45599c7f but I don't see a commit with that hash in the Go repo.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 5, 2019

(In particular I'm wondering whether that build included https://golang.org/cl/204937 == 04e80fb).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.