Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: should not parse comments inside most markdown #36684

Open
bradfitz opened this issue Jan 21, 2020 · 2 comments
Open

x/build/cmd/gopherbot: should not parse comments inside most markdown #36684

bradfitz opened this issue Jan 21, 2020 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 21, 2020

In #36508 (comment) @ianlancetaylor told somebody how to remove a label later and put the instructions in backticks but gopherbot still parsed it.

It should try a bit to avoid finding directives in formatted text.

/cc @andybons @dmitshur @toothrot

@gopherbot gopherbot added this to the Unreleased milestone Jan 21, 2020
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jan 21, 2020

And here's the opposite, also a parsing bug:

#36626 (comment)

... @ianlancetaylor tried to work around the parsing by adding lots of backticks to confuse gopherbot, but it confused it instead into parsing the gibberish as a request to add a label.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jan 21, 2020

This also happened in #35482 (comment). /cc @toothrot

I agree gopherbot can be improved so it's easier to insert instructions for how to use it without unintentionally triggering said command. It's helpful to include data in this thread, so that any potential fix is easier to evaluate.

To share a workaround I tend to use, I rely on inserting zero-width space (https://en.wikipedia.org/wiki/Zero-width_space) inside the keywords when I want to explicitly prevent gopherbot from taking some action. For example:

@​gopher​bot ple​ase add label Waiting​ForInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants