cmd/link: trailing padding after "Go" in ELF note name

[mdempsky]

https://www.sco.com/developers/gabi/latest/ch5.pheader.html#note_section says [emphasis added]:

namesz and name
The first namesz bytes in name contain a null-terminated character representation of the entry's owner or originator. There is no formal mechanism for avoiding name conflicts. By convention, vendors use their own name, such as XYZ Computer Company, as the identifier. If no name is present, namesz contains 0. Padding is present, if necessary, to ensure 8 or 4-byte alignment for the descriptor (depending on whether the file is a 64-bit or 32-bit object). Such padding is not included in namesz.

It looks like we get this right for the "NetBSD" tag, where we include a single nul-terminator character within the name (as measured by namesz), but then include an extra padding zero-byte for alignment.

However, for the "Go" tag, we include an extra nul-terminator within the name itself. The second nul-terminator should actually be padding.

Pointed out by Mark Kettenis from OpenBSD.

/cc @4a6f656c

[tpaschalis]

@mdempsky
Hello! I've created this small commit, which I think might be the fix.

As I'm not very experienced with ELF definitions, do you mind doing a sanity-check? If I'm on the right track I will open a CL.

[ianlancetaylor]

Seems fine. I don't think you need ELF_NOTE_GO_NAMESZ.

[gopherbot]

Change https://golang.org/cl/217857 mentions this issue: cmd/link : add trailing padding after Go ELF note

[odeke-em]

Hey Ian, in the CL we changed our confidence of the proposed fix. Would you advise moving this issue to the next milestone or shall we work on it through Go1.15? Thank you.

[tpaschalis]

Hey @odeke-em. From my side, I tried to debug the issue, but locally the toolchain is built correctly and all tests pass; I have no clue how to debug the Try-Bots, so I don't know how easy/hard the fix would be.

Both ./all.bash and GOOS=darwin GOARCH=amd64 ./bootstrap.bash seem to work. I'll rebase and send the commit again just in case.

[ianlancetaylor]

This doesn't seem to be urgent so changing milestone to Backlog.

[gopherbot]

Change https://go.dev/cl/477235 mentions this issue: cmd/link: add trailing padding after Go ELF note