Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support and documentation for bazel-based projects #37205

Open
gonzojive opened this issue Feb 13, 2020 · 5 comments
Open

x/tools/gopls: support and documentation for bazel-based projects #37205

gonzojive opened this issue Feb 13, 2020 · 5 comments

Comments

@gonzojive
Copy link

@gonzojive gonzojive commented Feb 13, 2020

What version of Go are you using (go version)?

$ go version
go version go1.13.1 linux/amd64

Does this issue reproduce with the latest release?

n/a

What operating system and processor architecture are you using (go env)?

n/a

What did you do?

Wrote a project with bazel with .go files and .proto files. The protobufs generate go code, which I'm not sure how to make understandable to gopls. Code completion for this code does not work in VSCode.

What did you expect to see?

  1. Documentation of how to set up a Bazel-based project in the User guide.
  2. An example project that works and loads in an IDE like VS Code

What did you see instead?

Scattered information on the level of support and no example projects.

Related links:

  1. bazelbuild/rules_go#512 - main source of updates on gopackagesdriver progress
  2. https://github.com/bazelbuild/rules_go/wiki/Editor-and-tool-integration: Design doc for gopackagesdriver - I'm not sure how accurate this is
  3. microsoft/vscode-go#2755 - gopls support for GOPACKAGESDRIVER in VS Code
  4. bazelbuild/rules_go#393 - editor integration issue for rules_go
  5. #34341 - documentation request for GOPACKAGESDRIVER
  6. Code: jmhodges/rules_go/go/tools/gopackagesdriver, gopackagesdriver in rules_go feature branch, tools/go/packages/external.go seems to implement the external packages driver
@gopherbot gopherbot added this to the Unreleased milestone Feb 13, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 13, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gonzojive gonzojive changed the title x/tools/gopls: Support and document for bazel-based projects x/tools/gopls: Support and documentation for bazel-based projects Feb 13, 2020
@stamblerre stamblerre changed the title x/tools/gopls: Support and documentation for bazel-based projects x/tools/gopls: support and documentation for bazel-based projects Feb 13, 2020
@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Feb 13, 2020

Did you use @jmhodges's Bazel implementation for GOPACKAGESDRIVER when you tried out gopls with Bazel? Is it ready for use?

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Feb 13, 2020
@gonzojive

This comment has been minimized.

Copy link
Author

@gonzojive gonzojive commented Feb 17, 2020

I did not try out jmhodge's implementation yet - I just browsed the code there.

@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Feb 18, 2020

I see. We don't support any build system that doesn't have an official gopackagesdriver, so I will defer to @jmhodges and @jayconrod on the status of that work.

@jayconrod

This comment has been minimized.

Copy link
Contributor

@jayconrod jayconrod commented Feb 18, 2020

Tracking issue for that is bazelbuild/rules_go#512.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.