cmd/go: 'go mod vendor' does not fail on case-insensitive import collision #38571
Comments
I will work on this |
justplesh
added a commit
to justplesh/go
that referenced
this issue
May 2, 2020
The existing implementation of go mod vendor allows having case-insensitive imports, which will anyway fail during go build. This improvement validates such collisions during any mod pkg loads ('tidy', 'why', 'vendor'). Fixes golang#38571
justplesh
added a commit
to justplesh/go
that referenced
this issue
May 2, 2020
The existing implementation of go mod vendor allows having case-insensitive imports, which will anyway fail during go build. This improvement validates such collisions during any mod pkg loads ('tidy', 'why', 'vendor'). Fixes golang#38571
Change https://golang.org/cl/231679 mentions this issue: |
@jayconrod any chance to get a review? |
@justplesh I think @bcmills would be a better reviewer for this. I haven't read through the full discussion in #38342 or thought about all the implications. |
@bcmills would appreciate |
justplesh
added a commit
to justplesh/go
that referenced
this issue
Sep 10, 2020
The existing implementation of go mod vendor allows having case-insensitive imports, which will anyway fail during go build. This improvement validates such collisions during any mod pkg loads ('tidy', 'why', 'vendor'). Fixes golang#38571
justplesh
added a commit
to justplesh/go
that referenced
this issue
Sep 10, 2020
The existing implementation of go mod vendor allows having case-insensitive imports, which will anyway fail during go build. This improvement validates such collisions during go mod vendor command. Fixes golang#38571
justplesh
added a commit
to justplesh/go
that referenced
this issue
Sep 27, 2020
The existing implementation of go mod vendor allows having case-insensitive imports, which will anyway fail during go build. This improvement validates such collisions during go mod vendor command. Fixes golang#38571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What did you do?
During the investigation of #38342, I discovered the following ux quirk:
On a case insensitive filesystem: (I am using
vfat
)What did you expect to see?
What did you see instead?
go mod vendor
succeeds, butgo build
fails, and one must flushvendor
to fix things:The text was updated successfully, but these errors were encountered: