Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.dev: docker/docker/client majorly out of date #38799

Closed
stevenh opened this issue May 1, 2020 · 2 comments
Closed

go.dev: docker/docker/client majorly out of date #38799

stevenh opened this issue May 1, 2020 · 2 comments

Comments

@stevenh
Copy link
Contributor

stevenh commented May 1, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/docker/docker/client?tab=doc

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36

Screenshot

image

What did you do?

Load the page

What did you expect to see?

Up to date docs

What did you see instead?

Docs from the 2017 version where as godoc.org seems correct and has the NewClientWithOpts constructor e.g.
https://godoc.org/github.com/docker/docker/client#NewClientWithOpts

@gopherbot gopherbot added this to the Unreleased milestone May 1, 2020
@myitcv
Copy link
Member

myitcv commented May 1, 2020

Related to/dup of #36811

@julieqiu
Copy link
Member

julieqiu commented May 2, 2020

Thanks for the feedback, @stevenh!

pkg.go.dev shows the "latest" version of a module, which is defined in https://golang.org/cmd/go/#hdr-Module_queries as the latest available tagged version, or else the underlying source repository's latest untagged revision.

In this case, the latest version of github.com/docker/docker is v1.13.1. You can confirm this by visiting
https://proxy.golang.org/github.com/docker/docker/@latest, which at this moment returns the following:

{
"Version": "v1.13.1",
"Time": "2017-02-08T05:58:41Z"
}

You can visit https://golang.org/cmd/go/#hdr-Module_proxy_protocol for details on the @latest endpoint.

In contrast, godoc.org shows the version of documentation at master, since it does not support modules.

As @myitcv mentioned, we are working on providing better support for viewing documentation at master for pkg.go.dev (#36811). In the meantime, you can use this workaround to view the documentation at master for godoc.org/github.com/docker/docker/client.

Closing as a duplicate of #36811.

@julieqiu julieqiu closed this as completed May 2, 2020
@golang golang locked and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants