Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.dev: incorrect latest version reported for cuelang.org/go #39300

Closed
myitcv opened this issue May 28, 2020 · 5 comments
Closed

go.dev: incorrect latest version reported for cuelang.org/go #39300

myitcv opened this issue May 28, 2020 · 5 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented May 28, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/cuelang.org/go?tab=doc

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.66 Safari/537.36

Screenshot

Screen Shot 2020-05-28 at 15 25 43

What did you do?

Visited the above page.

What did you expect to see?

v0.2.0 as the latest, per the proxy:

cd $(mktemp -d)
go mod init mod.com
go list -m -versions cuelang.org/go

gives:

cuelang.org/go v0.0.2 v0.0.3 v0.0.4-rc1 v0.0.4 v0.0.5 v0.0.6 v0.0.7 v0.0.8 v0.0.9 v0.0.10 v0.0.11 v0.0.12 v0.0.13 v0.0.14 v0.0.15 v0.1.0 v0.1.1 v0.1.2 v0.2.0

What did you see instead?

pkg.go.dev showing the latest version as v0.2.1.

cc @julieqiu

@mvdan
Copy link
Member

@mvdan mvdan commented May 28, 2020

Funnily enough, if you click on the v0.2.1, the URL shows a pseudo-version: https://pkg.go.dev/cuelang.org/go@v0.2.1-0.20200528045923-78cc785c3891?tab=doc

The UI doesn't show any other versions like the real v0.2.0, so maybe the issue is that it somehow forgot that there are tags, so it falls back to just showing the latest pseudoversion for master.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 28, 2020

I think this is because of #39244.

v0.2.1-0.20200528045923-78cc785c3891 is the only known version to pkg.go.dev where cuelang.org/go is the import path for a package. At v0.2.0, it looks like cuelang.org/go is a directory/module path, but not an import path.

@myitcv
Copy link
Member Author

@myitcv myitcv commented May 28, 2020

I think this is because of #39244.

It looks related.

So just to confirm, with the fix to #39244, https://pkg.go.dev/cuelang.org/go?tab=doc would take me to module view of v0.2.0 (because that is currently the latest module version at the time of writing)?

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 28, 2020

With that fix, https://pkg.go.dev/cuelang.org/go will take you to the current page at https://pkg.go.dev/cuelang.org/go@v0.2.0, which is currently what we show when a path is never a package. For example: https://pkg.go.dev/golang.org/x/tools.

We are also working on merging the "/" and "/mod/" views, but that will be addressed more holistically with other UX feedback.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 28, 2020

Closing this issue as a duplicate of #39244. Also related is #38087.

@julieqiu julieqiu closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.