Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: improve the examples to show that StatusCode checking is necessary #39778

Open
odeke-em opened this issue Jun 23, 2020 · 2 comments
Open
Milestone

Comments

@odeke-em
Copy link
Member

@odeke-em odeke-em commented Jun 23, 2020

Coming here from an offline debugging session with @indragiek, in which stacked in a bunch of services was a call to an HTTP service that matched the exact pattern from our net/http example on Get https://golang.org/pkg/net/http/#example_Get
Screen Shot 2020-06-23 at 1 42 29 AM

in that code we aren't checking for status codes, which I've seen in live code and just caused a bit of time wastage for a company. Given that the examples that we post will be copied as authoritative , we need to fix this up.

@odeke-em
Copy link
Member Author

@odeke-em odeke-em commented Jun 23, 2020

@indragiek might be interested in fixing this.

@cagedmantis cagedmantis added this to the Backlog milestone Jun 23, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.