Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: data race on done between Run() and Log() #41864

Closed
fraenkel opened this issue Oct 8, 2020 · 2 comments
Closed

testing: data race on done between Run() and Log() #41864

fraenkel opened this issue Oct 8, 2020 · 2 comments

Comments

@fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Oct 8, 2020

Using 1.15.2

WARNING: DATA RACE
Read at 0x00c0002dedc3 by goroutine 25
  testing.(*common).logDepth()
      /usr/local/go/src/testing/testing.go:736 +0xa9
  testing.(*common).log()
      /usr/local/go/src/testing/testing.go:729 +0x8f
  testing.(*common).Logf()
      /usr/local/go/src/testing/testing.go:775 +0x21
  testing.(*T).Logf()

Previous write at 0x00c0002dedc3 by goroutine 20
  testing.tRunner.func1()
      /usr/local/go/src/testing/testing.go:1113 +0x484
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1131 +0x22a

Just looks like we are missing a lock/unlock pair.

@ALTree
Copy link
Member

@ALTree ALTree commented Oct 8, 2020

Please post a code sample that triggers the problem.

@fraenkel
Copy link
Contributor Author

@fraenkel fraenkel commented Oct 8, 2020

dupe of #40343

@fraenkel fraenkel closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants