Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
net/http: should stop logging received GOAWAY #42142
What version of Go are you using (
Sounds like a bug to me, and indeed the linked discussion seems to suggest we should have removed those long time ago.
Looking at the code there seem to be already some logic to conditionally log these:
So we should either change the first message to include the error or just default to call
Since this doesn't seem like a particularly useful message unless stuff is being run in debug mode I would be in favor of the latter.
I don't have a strong opinion on either solutions but I'd be happy to prepare a CL to do either.