Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: ICE due to bad ORL constant [1.14 backport] #42755

Closed
gopherbot opened this issue Nov 20, 2020 · 3 comments
Closed

cmd/compile: ICE due to bad ORL constant [1.14 backport] #42755

gopherbot opened this issue Nov 20, 2020 · 3 comments
Assignees
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2020

@randall77 requested issue #42753 to be considered for backport to the next 1.14 minor release.

@gopherbot please open backport issue for 1.14.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 20, 2020

Change https://golang.org/cl/272030 mentions this issue: [release-branch.go1.14] cmd/compile: sign extend constant folding properly

Loading

@randall77 randall77 self-assigned this Nov 20, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 20, 2020

Approving as it is a serious issue without a good workaround. This backport applies to both 1.15 (#42753) and 1.14 (this issue).

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 3, 2020

Closed by merging 679482f to release-branch.go1.14.

Loading

@gopherbot gopherbot closed this Dec 3, 2020
gopherbot pushed a commit that referenced this issue Dec 3, 2020
…perly

MOVLconst must have a properly sign-extended auxint constant.
The bit operations in these rules don't enforce that invariant.

Fixes #42755

Change-Id: I729afcad18752d9b7739e49709020e3be7b3653e
Reviewed-on: https://go-review.googlesource.com/c/go/+/272030
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants