You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had hard time resulting only a failure to get cross-company CLA signed, thus I'm not filing a PR, but the change is trivial. Please consider applying it.
The reasoning is that most developers use (faster) amd64 machines setting the test timeouts, but test may run on slower arm ones and also different tests may suffer different relative slowdown on the arm CPUs.
Due to those two varying factors it is safer to allow a higher timeout scale on arm to avoid tests timing out.
The text was updated successfully, but these errors were encountered:
Thank you for the quick replies. The problem was not unique, we observed timeouts in multiple packages. Also the armhf test runners are slower machines than the ones running test for other architectures and I expect this to be typical. Since the timeout scale default is already set by architecture I think relaxing it for arm makes sense. Or there could be different default scales for 64 bit and 32 bit arm architectures.
For reference: #10314 (cmd/dist: default timeout value is too short for weaker CPUs), and #16106. Solved by introducing the GO_TEST_TIMEOUT_SCALE variable @cherrymui mentioned, in 7579867.
Instead of increasing timeoutScale or skipping tests, this CL
introduces an environment variable $GO_TEST_TIMEOUT_SCALE that
could be set to manually set a larger timeoutScale for those
changed the title
Please user higher test timeout scale for ARM
cmd/dist: request to increase user higher test timeout scale for ARM
Dec 4, 2020