Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036

Closed
maruel opened this issue Dec 6, 2020 · 3 comments
Closed

pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036

maruel opened this issue Dec 6, 2020 · 3 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
pkgsite/godoc.org...

Comments

@maruel
Copy link
Contributor

maruel commented Dec 6, 2020

Discovered while investigating #43035 :

pkg.go.dev fails at loading a non-ascii package name https://pkg.go.dev/github.com/maruel/panicparse/v2/cmd/panic/internal/%C3%B9tf8
but godoc succeeds: https://godoc.org/github.com/maruel/panicparse/cmd/panic/internal/%c3%b9tf8

Feels like a regression to me. @julieqiu
@maruel maruel mentioned this issue Dec 6, 2020
Closed
@julieqiu julieqiu added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. pkgsite labels Dec 7, 2020
@julieqiu
Copy link
Contributor

julieqiu commented Dec 7, 2020

Marking this as WaitingForInfo on #43035. Pkg.go.dev currently skips import paths that don't pass module.CheckImportPath.

@julieqiu julieqiu added this to the pkgsite/unplanned milestone Dec 7, 2020
@maruel
Copy link
Contributor Author

maruel commented Dec 7, 2020

Since #43035 is WAI and there's going to be a release note as per #43052, you can mark it WAI. Maybe worth pinging Bryan to clarify that pkg.go.dev enforces this too.

@julieqiu
Copy link
Contributor

julieqiu commented Dec 7, 2020

SGTM - closing as WAI.

/cc @bcmills @jayconrod @matloob

@julieqiu julieqiu closed this as completed Dec 7, 2020
@imjasonh imjasonh mentioned this issue Jan 28, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
pkgsite/godoc.org-redirect
Development

No branches or pull requests
3 participants
@maruel @julieqiu @gopherbot