Repository navigation
pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036
Description
Discovered while investigating #43035 :
pkg.go.dev fails at loading a non-ascii package name https://pkg.go.dev/github.com/maruel/panicparse/v2/cmd/panic/internal/%C3%B9tf8
but godoc succeeds: https://godoc.org/github.com/maruel/panicparse/cmd/panic/internal/%c3%b9tf8
Feels like a regression to me. @julieqiu
Activity
julieqiu commentedon Dec 7, 2020
Marking this as
WaitingForInfoon #43035. Pkg.go.dev currently skips import paths that don't pass module.CheckImportPath.maruel commentedon Dec 7, 2020
Since #43035 is WAI and there's going to be a release note as per #43052, you can mark it WAI. Maybe worth pinging Bryan to clarify that pkg.go.dev enforces this too.
julieqiu commentedon Dec 7, 2020
SGTM - closing as WAI.
/cc @bcmills @jayconrod @matloob