Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036

Closed
maruel opened this issue Dec 6, 2020 · 3 comments
Closed

Comments

@maruel
Copy link
Contributor

@maruel maruel commented Dec 6, 2020

Discovered while investigating #43035 :

pkg.go.dev fails at loading a non-ascii package name https://pkg.go.dev/github.com/maruel/panicparse/v2/cmd/panic/internal/%C3%B9tf8
but godoc succeeds: https://godoc.org/github.com/maruel/panicparse/cmd/panic/internal/%c3%b9tf8

Feels like a regression to me. @julieqiu

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Dec 7, 2020

Marking this as WaitingForInfo on #43035. Pkg.go.dev currently skips import paths that don't pass module.CheckImportPath.

@julieqiu julieqiu added this to the pkgsite/unplanned milestone Dec 7, 2020
@maruel
Copy link
Contributor Author

@maruel maruel commented Dec 7, 2020

Since #43035 is WAI and there's going to be a release note as per #43052, you can mark it WAI. Maybe worth pinging Bryan to clarify that pkg.go.dev enforces this too.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Dec 7, 2020

SGTM - closing as WAI.

/cc @bcmills @jayconrod @matloob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants