Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: better error message for "..." related error #43674

Closed
griesemer opened this issue Jan 13, 2021 · 6 comments
Closed

cmd/compile: better error message for "..." related error #43674

griesemer opened this issue Jan 13, 2021 · 6 comments
Labels
FrozenDueToAge NeedsFix
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Jan 13, 2021

package p
func _(..., float32)

produces: "syntax error: final argument in variadic function missing type" . The ... is not with the final argument.

@griesemer griesemer added the NeedsFix label Jan 13, 2021
@griesemer griesemer added this to the Go1.17 milestone Jan 13, 2021
@griesemer griesemer self-assigned this Jan 13, 2021
@Hallicopter
Copy link

@Hallicopter Hallicopter commented Apr 14, 2021

Is this something that can be a good first issue? If so, where do you suggest I start?

I will reproduce this issue, and see what can be done in the meanwhile.

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Apr 14, 2021

@Hallicopter Thanks for your interest but I prefer to fix this one myself. Thanks.

@Hallicopter
Copy link

@Hallicopter Hallicopter commented Apr 14, 2021

Oh okay, cool, no problem.

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Apr 14, 2021

@Hallicopter If you are looking for "starter issues" look at issued labeled "suggested". Thanks.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 14, 2021

Change https://golang.org/cl/310209 mentions this issue: cmd/compile/internal/syntax: better error message for ... without type

@Hallicopter
Copy link

@Hallicopter Hallicopter commented Apr 15, 2021

Thanks, @griesemer! Just wanted to contribute back to Go in some way since it has helped me so much.

@golang golang locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix
Projects
None yet
Development

No branches or pull requests

3 participants